PHP 8 upgrade #74
Merged
PHP 8 upgrade #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E_NONE is neither a string nor a real constant
Fix later
UNION selects return unique values, resulting in one or the other potentially being null if both results match Fixing the union statement deals with the null value, but probably good to ensure minimums when dividing anyway
Merged
|
@Aokromes I believe this is good to go. |
Made redundant by the Cache-Control header
Also fix favicon convention
flashadvocate
commented
Dec 24, 2022
| @@ -24,7 +24,7 @@ function connect($db_host, $db_username, $db_password, $db_name = NULL, $use_nam | |||
|
|
|||
| if ($this->link_id){ | |||
| if (!empty($use_names)) $this->query("SET NAMES '$use_names'"); | |||
| } else die($lang_global['err_sql_conn_db']); | |||
| } else die($lang_global['err_sql_conn_db'] . " DB: {$db_name}"); | |||
There was a problem hiding this comment.
Added this to make it more clear which database is failing, since the default error language does not make it obvious, and there's several potential culprits
flashadvocate
commented
Dec 24, 2022
| @@ -192,6 +192,7 @@ function top100($realmid, &$sqlr, &$sqlc) | |||
| <td>'.char_get_level_color($char['level']).'</td>'; | |||
| if ($type === 'level') | |||
| { | |||
| // @TODO - fix N+ issue - query inside while loop | |||
| $guild_name = $sqlc->result($sqlc->query('SELECT BINARY name AS name FROM guild WHERE guildid = '.$char['gname'].''), 0); | |||
There was a problem hiding this comment.
N+1 query issue here, probably shouldn't be inside the loop. Need to eager load this information elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to function fine in PHP 7.4 all the way up to PHP 8.2. Of course 74 is now EOL so folks should move at least to 8.0. This PR fixes a few things that become fatal errors in PHP 8, as well as a few other minor housekeeping changes.
Also adds a docker environment including the two PHP extension dependencies (
php-gp, and mysqli) as well as PHP 8.0. The mysql init script handles themmftcdatabase population, but stops short of injecting the DBC.